libxc: fix bug in xc_tbuf_get_size()
authorKeir Fraser <keir.fraser@citrix.com>
Wed, 10 Feb 2010 13:30:16 +0000 (13:30 +0000)
committerKeir Fraser <keir.fraser@citrix.com>
Wed, 10 Feb 2010 13:30:16 +0000 (13:30 +0000)
The size in pages of trace buffer should be t_info->tbuf_size
rather than t_info pages.

Signed-off-by: Yu Zhiguo <yuzg@cn.fujitsu.com>
tools/libxc/xc_tbuf.c

index 3948d0af7dcfdb2f2e23bde4113a248083b27460..aa21d849bb9fa9533160224ecee5a878e39883b5 100644 (file)
@@ -15,6 +15,7 @@
  */
 
 #include "xc_private.h"
+#include <xen/trace.h>
 
 static int tbuf_enable(int xc_handle, int enable)
 {
@@ -44,6 +45,7 @@ int xc_tbuf_set_size(int xc_handle, unsigned long size)
 
 int xc_tbuf_get_size(int xc_handle, unsigned long *size)
 {
+    struct t_info *t_info;
     int rc;
     DECLARE_SYSCTL;
 
@@ -52,9 +54,19 @@ int xc_tbuf_get_size(int xc_handle, unsigned long *size)
     sysctl.u.tbuf_op.cmd  = XEN_SYSCTL_TBUFOP_get_info;
 
     rc = xc_sysctl(xc_handle, &sysctl);
-    if (rc == 0)
-        *size = sysctl.u.tbuf_op.size;
-    return rc;
+    if ( rc != 0 )
+        return rc;
+
+    t_info = xc_map_foreign_range(xc_handle, DOMID_XEN,
+                    sysctl.u.tbuf_op.size, PROT_READ | PROT_WRITE,
+                    sysctl.u.tbuf_op.buffer_mfn);
+
+    if ( t_info == NULL || t_info->tbuf_size == 0 )
+        return -1;
+
+    *size = t_info->tbuf_size;
+
+    return 0;
 }
 
 int xc_tbuf_enable(int xc_handle, unsigned long pages, unsigned long *mfn,